Replace FrameLayout with FragmentContainerView where applicable#5882
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Mar 27, 2021
TacoTheDank:fragmentcontainerview
Merged
Replace FrameLayout with FragmentContainerView where applicable#5882Stypox merged 1 commit intoTeamNewPipe:devfrom TacoTheDank:fragmentcontainerview
Stypox merged 1 commit intoTeamNewPipe:devfrom
TacoTheDank:fragmentcontainerview
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
triallax
added
codequality
Redirion
reviewed
Mar 26, 2021
This was referenced Apr 11, 2021
Closed
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 23, 2021
…containerview Replace FrameLayout with FragmentContainerView where applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
https://github.com/TeamNewPipe/NewPipe/suites/2319358795/artifacts/48762467
I tested with my Android 10 phone and everything worked fine. However, I need people with tablets and tvs to test the video details page and make sure the related streams section works properly, please!
Due diligence